Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc peakcall 2797 #1478

Merged
merged 111 commits into from
Feb 5, 2025
Merged

Rc peakcall 2797 #1478

merged 111 commits into from
Feb 5, 2025

Conversation

rsc3
Copy link
Collaborator

@rsc3 rsc3 commented Jan 14, 2025 •
edited by aawdeh
Loading

Description

Added the peakcalling step in ATAC.

  • This currently does not assign any outputs. (Done)
  • Currently peakcalling is turned on. (Done)
  • Validated by running on human and mouse scientific data.

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Remember to squash merge!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@ekiernan
Copy link
Contributor

ekiernan commented Feb 5, 2025

retesting Multiome Smart-test with truth data in gotc-truth: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/100937/

@ekiernan
Copy link
Contributor

ekiernan commented Feb 5, 2025

retest this please

ekiernan
ekiernan approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ekiernan ekiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this!

aawdeh
aawdeh approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@aawdeh aawdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsc3 rsc3 merged commit 7fdbae2 into develop Feb 5, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khajoue2 khajoue2 khajoue2 approved these changes

@aawdeh aawdeh aawdeh approved these changes

@ekiernan ekiernan ekiernan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rsc3 @ekiernan @khajoue2 @aawdeh @actions-user